Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17435 )
Change subject: IMPALA-10489: Implement JWT support ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/17435/7/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/17435/7/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@433 PS7, Line 433: "--jwt_token_auth=true --jwt_validate_signature=true --jwks_file_path=%s --jwt_allow_without_tls=true", line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17435/7/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@494 PS7, Line 494: "--jwt_token_auth=true --jwt_validate_signature=false --jwt_allow_without_tls=true"); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17435/7/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java: http://gerrit.cloudera.org:8080/#/c/17435/7/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@289 PS7, Line 289: "--jwt_token_auth=true --jwt_validate_signature=true --jwks_file_path=%s --jwt_allow_without_tls=true", line too long (115 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b71fa854c9ddc8ca882878853395e1eb866143c Gerrit-Change-Number: 17435 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 21 May 2021 19:02:50 +0000 Gerrit-HasComments: Yes