Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17308 )
Change subject: IMPALA-10502: Handle CREATE/DROP events correctly ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/17308/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17308/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1764 PS6, Line 1764: > nit: I think we should check events.size() > 0 makes sense. To improve the readability I added another Preconditions.checkState(!events.isEmpty()) above and kept this line same as earlier. http://gerrit.cloudera.org:8080/#/c/17308/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1796 PS6, Line 1796: and the table object from the event. > nit: (useLatestEvent && !events.isEmpty()) || events.size() == 1 same as my other comment about Preconditions.checkState(!events.isEmpty()) http://gerrit.cloudera.org:8080/#/c/17308/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4915 PS6, Line 4915: String cachePoolName = null; : Short replication = null; > Not sure about the latest hive changes, but is it safe to add all partition if you look at the implementation of addHmsPartitions it adds the partitions in batches of MAX_PARTITION_UPDATES_PER_RPC so logically the before and after are same. -- To view, visit http://gerrit.cloudera.org:8080/17308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c5e96b48abac015240f20295b3ec3b1d71f24a Gerrit-Change-Number: 17308 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 24 May 2021 19:19:31 +0000 Gerrit-HasComments: Yes
