Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 )
Change subject: IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/17298/8/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17298/8/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@843 PS8, Line 843: e > I just realize that ALTER TABLE RENAME TO is also handled here. So I think Good catch ! For alter_table cases, we can instead call renameTable method in CatalogServiceCatalog. The signature of the method is: // Renames a table. Equivalent to an atomic drop + add of the table. public Pair<Table, Table> renameTable( TTableName oldTableName, TTableName newTableName) Thoughts? cc - @Vihang http://gerrit.cloudera.org:8080/#/c/17298/8/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/17298/8/tests/custom_cluster/test_metastore_service.py@449 PS8, Line 449: """ > Could you add a test for renaming the table name, and verify that the old t Sure will add a test for rename table. -- To view, visit http://gerrit.cloudera.org:8080/17298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb9cc22ebfb51948433e4d57f4705ce201acaf98 Gerrit-Change-Number: 17298 Gerrit-PatchSet: 13 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 25 May 2021 17:27:36 +0000 Gerrit-HasComments: Yes
