Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17524 )
Change subject: IMPALA-10720: Add versioning to admission heartbeats ...................................................................... Patch Set 1: (4 comments) A few nits http://gerrit.cloudera.org:8080/#/c/17524/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17524/1//COMMIT_MSG@10 PS1, Line 10: allows the admission service to ignore stale heartbeats from Maybe clarify that stale here means out of order? http://gerrit.cloudera.org:8080/#/c/17524/1/be/src/scheduling/admission-control-service.h File be/src/scheduling/admission-control-service.h: http://gerrit.cloudera.org:8080/#/c/17524/1/be/src/scheduling/admission-control-service.h@138 PS1, Line 138: /// Maps from coordiantor ID to the latest heartbeat version number that was processed Nit: "coordinator" http://gerrit.cloudera.org:8080/#/c/17524/1/be/src/scheduling/admission-control-service.h@140 PS1, Line 140: std::unordered_map<UniqueIdPB, int64_t> coord_id_to_heartbeat_; I think this map will contains stale data form coordinators that have restarted. I think you would need really pathological restarting for the memory leakage to be noticeable. It might be worth noting that the map can contain old data. http://gerrit.cloudera.org:8080/#/c/17524/1/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/17524/1/be/src/scheduling/admission-control-service.cc@276 PS1, Line 276: VLOG(1) << "Stale heartbeat received for coord_id: "<< req->host_id(); Maybe should also say that this may be expected if a coordinator restarts. -- To view, visit http://gerrit.cloudera.org:8080/17524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1338211dc0bca67f8fde93a1b05c0780be583d5d Gerrit-Change-Number: 17524 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Fri, 28 May 2021 17:23:40 +0000 Gerrit-HasComments: Yes
