Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17560 )
Change subject: IMPALA-10735: Fix Iceberg insert when event polling is enabled ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17560/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17560/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5021 PS2, Line 5021: if (!BackendConfig.INSTANCE.isInsertEventsEnabled()) return false; : if (table instanceof FeIcebergTable) return false; : return true; Seems to me the test on iceberg tables can be done first, regardless of the current configuration/state of event processing. This is because the feature is not support for any iceberg tables. Also wonder why catalog_.isEventProcessingActive() is dropped. -- To view, visit http://gerrit.cloudera.org:8080/17560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4c3d7d4c0edf0d45628cf6d44785bad1049d76 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 09 Jun 2021 12:58:01 +0000 Gerrit-HasComments: Yes
