Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17560 )
Change subject: IMPALA-10735: Fix Iceberg insert when event polling is enabled ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17560/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17560/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5022 PS5, Line 5022: if (!BackendConfig.INSTANCE.isInsertEventsEnabled()) return false; I agree with sending events even if isEventProcessingActive() is false, but I would prefer to do this change in a different commit. It is cleaner if an Iceberg related commit has no non-Iceberg related side-effects. -- To view, visit http://gerrit.cloudera.org:8080/17560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4c3d7d4c0edf0d45628cf6d44785bad1049d76 Gerrit-Change-Number: 17560 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Jun 2021 15:23:07 +0000 Gerrit-HasComments: Yes
