Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17576 )

Change subject: Drop table/db from catalog cache when drop table/db HMS apis 
are accessed from catalog's metastore server.
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17576/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
File 
fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java:

http://gerrit.cloudera.org:8080/#/c/17576/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@467
PS1, Line 467:       Db removedDb = 
catalog_.removeDbIfExists(dbToDrop.getMetaStoreDb(), dbFound, dbMatched);
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/17576/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@3020
PS1, Line 3020:                                             String dbName, 
String tblName, String apiName) {
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/17576/1/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsParallelCreateDropTest.java
File 
fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsParallelCreateDropTest.java:

http://gerrit.cloudera.org:8080/#/c/17576/1/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsParallelCreateDropTest.java@46
PS1, Line 46:             "thrift://localhost:" + 
((CatalogServiceTestCatalog.CatalogServiceTestHMSCatalog) catalog_).getPort());
line too long (115 > 90)


http://gerrit.cloudera.org:8080/#/c/17576/1/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:

http://gerrit.cloudera.org:8080/#/c/17576/1/tests/custom_cluster/test_metastore_service.py@729
PS1, Line 729: p
flake8: F841 local variable 'prev_get_table_response' is assigned to but never 
used



--
To view, visit http://gerrit.cloudera.org:8080/17576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e2ad2630e2028b8ad26a6272ee766b27e0935c
Gerrit-Change-Number: 17576
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <soura...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 17:35:22 +0000
Gerrit-HasComments: Yes

Reply via email to