Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 )
Change subject: IMPALA-10557: Support Kudu's multi-row transaction ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/17553/8/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/17553/8/tests/custom_cluster/test_kudu.py@336 PS8, Line 336: class TestKuduTransaction(CustomClusterTestSuite): Another test case that might be worth adding is running two separate Impala queries that are inserting to the same Kudu partitions. One of the queries should fail, given Kudu's current implementation of partition locking. http://gerrit.cloudera.org:8080/#/c/17553/8/tests/custom_cluster/test_kudu.py@366 PS8, Line 366: query_options = {'debug_action': 'FIS_FAIL_KUDU_TABLE_SINK_BATCH:FAIL@1.0'} A more organic test might be to try inserting duplicate rows. That would exercise Impala's handling of Kudu row errors as well. Same below. -- To view, visit http://gerrit.cloudera.org:8080/17553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I876ada48991afdff5d61b5d6a0417571aba7cb34 Gerrit-Change-Number: 17553 Gerrit-PatchSet: 8 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Jun 2021 21:42:38 +0000 Gerrit-HasComments: Yes
