Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 )
Change subject: WIP: Reducing HashTable size by packing it's buckets efficiently. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17592/1/be/src/exec/hash-table.inline.h File be/src/exec/hash-table.inline.h: http://gerrit.cloudera.org:8080/#/c/17592/1/be/src/exec/hash-table.inline.h@184 PS1, Line 184: if ((!has_duplicates && bucket->is_matched()) || (has_duplicates && node->is_matched())) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17592/1/be/src/exec/hash-table.inline.h@194 PS1, Line 194: *node = stores_duplicates() ? buckets_[*bucket_idx].bucket_data()->duplicates : NULL; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17592/1/be/src/util/tagged-ptr.h File be/src/util/tagged-ptr.h: http://gerrit.cloudera.org:8080/#/c/17592/1/be/src/util/tagged-ptr.h@31 PS1, Line 31: /// canonical address is also 57-bit canonical. For 64-bit address line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/17592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72912ae9353b0d567a976ca712d2d193e035df9b Gerrit-Change-Number: 17592 Gerrit-PatchSet: 1 Gerrit-Owner: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Jun 2021 09:50:56 +0000 Gerrit-HasComments: Yes
