Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17595 )
Change subject: IMPALA-10723: Treat materialized view as a table instead of a view ...................................................................... Patch Set 5: (2 comments) Thanks Quanlong for the review. I will do some investigation of the LocalCatalog mode and address your review comments in the follow up. http://gerrit.cloudera.org:8080/#/c/17595/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17595/5//COMMIT_MSG@18 PS5, Line 18: makes the MVs a derived class of HdfsTable > 'HdfsTable' is not used in LocalCatalog mode coordinators. Does this patch It's good point about LocalCatalog mode. I will check it out and get back on this. Regarding MVs with Kudu, I doubt if that is a supported storage since the CREATE MATERIALIZED VIEW is only supported via Hive and Hive does not have Kudu as a storage option. http://gerrit.cloudera.org:8080/#/c/17595/5/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/17595/5/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3110 PS5, Line 3110: onTable("functional", "materialized_view", TPrivilegeLevel.SELECT)); > Could you add a more complex test that the number of srcTables of a MV is l Yes, I was in fact thinking of expanding the scope of the tests since previously I just used the materialized_view table that was already present. -- To view, visit http://gerrit.cloudera.org:8080/17595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3108996124c6544a97fb0c34b6aff5e324a6cff Gerrit-Change-Number: 17595 Gerrit-PatchSet: 5 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Sat, 19 Jun 2021 01:10:38 +0000 Gerrit-HasComments: Yes
