Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17308 )
Change subject: IMPALA-10502: Handle CREATE/DROP events correctly ...................................................................... Patch Set 19: (4 comments) http://gerrit.cloudera.org:8080/#/c/17308/18/tests/custom_cluster/test_event_processing.py File tests/custom_cluster/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/17308/18/tests/custom_cluster/test_event_processing.py@127 PS18, Line 127: > nit: indent should be +4 Done http://gerrit.cloudera.org:8080/#/c/17308/18/tests/custom_cluster/test_event_processing.py@167 PS18, Line 167: > nit: should be +4 indent Done http://gerrit.cloudera.org:8080/#/c/17308/18/tests/custom_cluster/test_event_processing.py@236 PS18, Line 236: @SkipIfHive2.acid this was redundant and hence removed. http://gerrit.cloudera.org:8080/#/c/17308/18/tests/custom_cluster/test_event_processing.py@310 PS18, Line 310: ] > nit: should be +4 indent Done -- To view, visit http://gerrit.cloudera.org:8080/17308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2c5e96b48abac015240f20295b3ec3b1d71f24a Gerrit-Change-Number: 17308 Gerrit-PatchSet: 19 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 18:38:06 +0000 Gerrit-HasComments: Yes