Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 )
Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/17389/6/be/src/util/string-parser.h File be/src/util/string-parser.h: http://gerrit.cloudera.org:8080/#/c/17389/6/be/src/util/string-parser.h@463 PS6, Line 463: FAILURE and 0 is retur > If we can change it to std::string(), we can take advantage of the fast_dou As discussed in other thread, changing it to std::string will need changes in many places even to other StringTo* functions. So we will retain this signature. http://gerrit.cloudera.org:8080/#/c/17389/6/be/src/util/string-parser.h@498 PS6, Line 498: of remaning string not parsed by li > We can pass the input std::string as 's' and get rid off 'len', This may not be required as only long strings will use std::string now and they would not need any preprocessing. http://gerrit.cloudera.org:8080/#/c/17389/6/be/src/util/string-parser.h@538 PS6, Line 538: : retur > The new signature of this function becomes This may not be required as only long strings will use std::string now and they would not need any preprocessing. http://gerrit.cloudera.org:8080/#/c/17389/6/be/src/util/string-parser.h@545 PS6, Line 545: DCHECK(trailing_ > In a message at Jun 3 you mentioned "So I will use VAC for shorter strings Have made the changes for the same now. For shorter string we will use stack and for longer string we will use std::string (malloc) http://gerrit.cloudera.org:8080/#/c/17389/6/be/src/util/string-parser.h@550 PS6, Line 550: > This would probably prevent "return value optimization", as there would be This code has changed now. We take care of not making a copy for null-terminated string at some other place. http://gerrit.cloudera.org:8080/#/c/17389/6/be/src/util/string-parser.h@552 PS6, Line 552: (val == std::numeric_limits<T>::infinity())) { > Do you plan to resolve this comment? This has been removed. -- To view, visit http://gerrit.cloudera.org:8080/17389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic105ad38a2fcbf2fb4e8ae8af6d9a8e251a9c141 Gerrit-Change-Number: 17389 Gerrit-PatchSet: 7 Gerrit-Owner: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Jul 2021 19:33:14 +0000 Gerrit-HasComments: Yes
