Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17683 )
Change subject: IMPALA-8762: Track host level admission stats across all cooridnators ...................................................................... Patch Set 1: (6 comments) I did a quick read through http://gerrit.cloudera.org:8080/#/c/17683/1/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/17683/1/be/src/scheduling/admission-controller.h@440 PS1, Line 440: // This struct stores per-host statistics which are used during admission and by HTTP Nit: Its not a struct any more http://gerrit.cloudera.org:8080/#/c/17683/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/17683/1/be/src/scheduling/admission-controller.cc@75 PS1, Line 75: // "POOL:<pool_name><delimiter><backend_id>". "!" is used because the backend id contains Nit: is it clearer to say it is of the form? <prefix>:<pool_name><delimiter><backend_id> http://gerrit.cloudera.org:8080/#/c/17683/1/be/src/scheduling/admission-controller.cc@244 PS1, Line 244: // Parses the topic key to sperate the prefix that helps recognize the kind of update Nit: separate http://gerrit.cloudera.org:8080/#/c/17683/1/be/src/scheduling/admission-controller.cc@245 PS1, Line 245: // recieved. Nit: received http://gerrit.cloudera.org:8080/#/c/17683/1/be/src/scheduling/admission-controller.cc@1652 PS1, Line 1652: if (topic_backend_id == host_id_) continue; This is skipping updates about the current host? http://gerrit.cloudera.org:8080/#/c/17683/1/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/17683/1/tests/custom_cluster/test_executor_groups.py@96 PS1, Line 96: self.num_executors = 2 why is this 2? -- To view, visit http://gerrit.cloudera.org:8080/17683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2946832e0a89b077d0f3bec755e4672be2088243 Gerrit-Change-Number: 17683 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Jul 2021 21:15:41 +0000 Gerrit-HasComments: Yes
