Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17654 )
Change subject: IMPALA-10627: Use standard parquet-related Iceberg table properties ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Thanks for applying the changes. http://gerrit.cloudera.org:8080/#/c/17654/6/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/17654/6/be/src/exec/parquet/hdfs-parquet-table-writer.cc@1150 PS6, Line 1150: ConfigureTimestampType(); : ConfigureStringType(); Now the implementation of these could be moved to Configure()/ConfigureForIceberg(). -- To view, visit http://gerrit.cloudera.org:8080/17654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b8aa9a52c13c41b48310d2f7c9c7426e1ff5f23 Gerrit-Change-Number: 17654 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 11:24:38 +0000 Gerrit-HasComments: Yes
