Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17688 )
Change subject: IMPALA-10799: Analysis slowdown with inline views and thousands of column ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Good find. 10K exprs in a select list is certainly pushing the boundaries. http://gerrit.cloudera.org:8080/#/c/17688/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17688/1//COMMIT_MSG@11 PS1, Line 11: check nit: 'checking' http://gerrit.cloudera.org:8080/#/c/17688/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/17688/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@331 PS1, Line 331: Map<String, Expr> existingAliasExprs = new LinkedHashMap<>(); nit: pls add a comment that this additional map is used for performance reasons and not for finding ambiguous alias. -- To view, visit http://gerrit.cloudera.org:8080/17688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43da47dddfdb3db6d0e2073ae974a0a4d1b3ad7c Gerrit-Change-Number: 17688 Gerrit-PatchSet: 1 Gerrit-Owner: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 16 Jul 2021 18:21:10 +0000 Gerrit-HasComments: Yes
