Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17716 )
Change subject: IMPALA-10821 Fix TestTPCHJoinQueries.test_outer_joins failed ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17716/1/testdata/workloads/tpch/queries/tpch-outer-joins.test File testdata/workloads/tpch/queries/tpch-outer-joins.test: http://gerrit.cloudera.org:8080/#/c/17716/1/testdata/workloads/tpch/queries/tpch-outer-joins.test@87 PS1, Line 87: '| 00:SC > Yes, it's better to use $FILESYSTEM_NAME. Done http://gerrit.cloudera.org:8080/#/c/17716/1/testdata/workloads/tpch/queries/tpch-outer-joins.test@87 PS1, Line 87: '| 00:SC > You could also use $FILESYSTEM_NAME here instead of regex. Yeah, $FILESYSTEM_NAME is better, thanks for the advice. Done. -- To view, visit http://gerrit.cloudera.org:8080/17716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e068d9da03517f8316e7a2505ce1466523d5917 Gerrit-Change-Number: 17716 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Sat, 24 Jul 2021 03:20:23 +0000 Gerrit-HasComments: Yes
