Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17703 )
Change subject: [WIP]: Initial commit to acquire table/database lock in metastore server before any HMS operation ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/17703/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/17703/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@428 PS4, Line 428: Acquire write lock on multiple tables > It might be good idea to move lock related methods to a separate class. Thi Sure. We can work on refactoring in a separate patch. Thoughts? http://gerrit.cloudera.org:8080/#/c/17703/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17703/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6201 PS4, Line 6201: > Are you going to flesh out these methods in this PR or that will be a separ I am thinking of creating a separate PR which would implement and use these methods. Want to restrict this PR to only acquiring db/table locks. -- To view, visit http://gerrit.cloudera.org:8080/17703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I085eab20db61282daf4549ddbcc018aaf63cc361 Gerrit-Change-Number: 17703 Gerrit-PatchSet: 4 Gerrit-Owner: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <kis...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Comment-Date: Thu, 29 Jul 2021 14:36:28 +0000 Gerrit-HasComments: Yes
