Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17612 )
Change subject: IMPALA-8795: Turn on events processing by default ...................................................................... Patch Set 12: Code-Review+1 (4 comments) Found a few nits, otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/17612/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17612/12//COMMIT_MSG@15 PS12, Line 15: withing within http://gerrit.cloudera.org:8080/#/c/17612/12/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/17612/12/tests/common/impala_service.py@137 PS12, Line 137: => nit: >= http://gerrit.cloudera.org:8080/#/c/17612/12/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/17612/12/tests/metadata/test_hms_integration.py@670 PS12, Line 670: turned turned on? http://gerrit.cloudera.org:8080/#/c/17612/12/tests/util/event_processor_utils.py File tests/util/event_processor_utils.py: http://gerrit.cloudera.org:8080/#/c/17612/12/tests/util/event_processor_utils.py@66 PS12, Line 66: nit: too much indent? -- To view, visit http://gerrit.cloudera.org:8080/17612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a8b1871a98b913d0ad8bb26a104a296b6a06122 Gerrit-Change-Number: 17612 Gerrit-PatchSet: 12 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Aug 2021 12:40:45 +0000 Gerrit-HasComments: Yes
