Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17706 )
Change subject: IMPALA-3430: Runtime filter : Extend runtime filter to support Min/Max values for HDFS scans ...................................................................... Patch Set 31: Code-Review+1 (2 comments) +1 LGTM. Just left one comment to change the commit message. http://gerrit.cloudera.org:8080/#/c/17706/29/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/17706/29/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@392 PS29, Line 392: // AggregationNode that implements a non-correlated scalar subquery > This form is particularly called for in the JIRA (https://gerrit.cloudera.o For non-aggregate scalar subqueries such conversions from "select ss_wholesale_cost from tpcds_parquet.store_sales" to "select min(ss_wholesale_cost) from tpcds_parquet.store_sales" may not always be semantically right like for "select ss_wholesale_cost from tpcds_parquet.store_sales limit 1". It is fine to just handle aggregate scalar subquery in this patch as it may be the most common case - but its better to mention that in commit message and also have a JIRA for extending it to non-aggregate ones too. http://gerrit.cloudera.org:8080/#/c/17706/29/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test: http://gerrit.cloudera.org:8080/#/c/17706/29/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@437 PS29, Line 437: ---- QUERY > The first one was added. Makes sense. -- To view, visit http://gerrit.cloudera.org:8080/17706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c2bb5baad622051d1002c9c162c672d428e5446 Gerrit-Change-Number: 17706 Gerrit-PatchSet: 31 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Aug 2021 13:56:50 +0000 Gerrit-HasComments: Yes
