Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 )
Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15403/2/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15403/2/be/src/exec/hdfs-orc-scanner.cc@881 PS2, Line 881: orc::Literal(*predicate_type, value) This is only used for DATE type: https://github.com/apache/orc/blob/36349d535089412b58f99c72af9bf7dcf7444aee/c%2B%2B/src/sargs/Literal.cc#L70 We should use another interface: https://github.com/apache/orc/blob/36349d535089412b58f99c72af9bf7dcf7444aee/c%2B%2B/include/orc/sargs/Literal.hh#L100 /** * Create a literal of DATE type */ Literal(PredicateDataType type, int64_t val); /** * Create a literal of TIMESTAMP type */ Literal(int64_t second, int32_t nanos); -- To view, visit http://gerrit.cloudera.org:8080/15403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136622413db21e0941d238ab6aeea901a6464845 Gerrit-Change-Number: 15403 Gerrit-PatchSet: 2 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (520) Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Aug 2021 09:18:31 +0000 Gerrit-HasComments: Yes