Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17756 )
Change subject: [WIP]: Initial commit: Add logic to sync to latest event id ...................................................................... Patch Set 12: (27 comments) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@752 PS12, Line 752: LOG.info("Skipping event {} on table {} since it is already synced till event id {}", line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@305 PS12, Line 305: throws CatalogException, MetastoreNotificationException, ImpalaRuntimeException { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@297 PS12, Line 297: private final String SYNC_TABLE_LATEST_EVENT_ID_ERR_MSG = "Failed to sync table %s to " + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@539 PS12, Line 539: public void create_table_with_constraints(org.apache.hadoop.hive.metastore.api.Table table, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@541 PS12, Line 541: List<SQLUniqueConstraint> sqlUniqueConstraints, List<SQLNotNullConstraint> sqlNotNullConstraints, line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@542 PS12, Line 542: List<SQLDefaultConstraint> sqlDefaultConstraints, List<SQLCheckConstraint> sqlCheckConstraints) line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@565 PS12, Line 565: public void create_table_with_environment_context(org.apache.hadoop.hive.metastore.api.Table table, line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@757 PS12, Line 757: boolean response = super.drop_partition_by_name(dbname, tblname, partName, deleteData); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@812 PS12, Line 812: if (!catalog_.tryWriteLock(new org.apache.impala.catalog.Table[] {srcTbl, destinationTbl})) { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@881 PS12, Line 881: super.alter_partitions_with_environment_context(dbName, tblName, list, environmentContext); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@888 PS12, Line 888: super.alter_partitions_with_environment_context(dbName, tblName, list, environmentContext); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1139 PS12, Line 1139: Preconditions.checkState(syncToLatestEventId_, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1175 PS12, Line 1175: notificationEvent -> MetastoreEvents.CreateTableEvent.CREATE_TABLE_EVENT_TYPE line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1228 PS12, Line 1228: TTableName oldTTable = new TTableName(oldMsTable.getDbName(), oldMsTable.getTableName()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1229 PS12, Line 1229: TTableName newTTable = new TTableName(newMsTable.getDbName(), newMsTable.getTableName()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1235 PS12, Line 1235: throw new CatalogException("failed to rename table " + oldTTable + " to " + newTTable + " " + line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1271 PS12, Line 1271: renameTable(currentEventId, newTable.getDbName(), newTable.getTableName(), apiName); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1277 PS12, Line 1277: getTableAndAcquireWriteLock(newTable.getDbName(), newTable.getTableName(), apiName); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@3155 PS12, Line 3155: LOG.debug("db {} does not exist in metastore. Removing it from catalog if exists ", line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2515 PS12, Line 2515: String tblName, Map<String, String> params, boolean isPartitioned) throws TException { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2640 PS12, Line 2640: public static void createTableFromImpala(CatalogOpExecutor catalogOpExecutor, String dbName, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3207 PS12, Line 3207: public static void addPartitions(MetaStoreClient msClient, String dbName, String tblName, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java: http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@177 PS12, Line 177: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@241 PS12, Line 241: assertTrue(eventsProcessor_.getLastSyncedEventId() == getLatestEventIdFromHMS()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@242 PS12, Line 242: assertTrue( String.format("CurrentSkippedCount %s differs from lastSkippedCount + 3 %s", line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@374 PS12, Line 374: private void createDatabaseInHms(String catName, String dbName, Map<String, String> params) line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/12/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@424 PS12, Line 424: private Partition getPartitionInHms(String dbName, String tblName, List<String> partVal) line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia822d15725d0a9a9ad1398e10ed4ae3288d0e9ad Gerrit-Change-Number: 17756 Gerrit-PatchSet: 12 Gerrit-Owner: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Aug 2021 17:52:52 +0000 Gerrit-HasComments: Yes
