Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 )
Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/17592/12/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/17592/12/be/src/exec/hash-table.h@705 PS12, Line 705: If bucket doesn't have tag fields set, TAGGED can : /// be set to 'false' to avoid extra bit operations. > nit. I think the following may describe the semantics better: 'IF' is upon boolean template parameter, so compiler will do dead branch elimination at compile time and it will not be a branch statement anymore after compilation. It's the same reason why LIKELY or UNLIKELY is not needed. Reg comment, it describes 'false' value on purpose rather than 'true'. The reason is class definition and description in comment clearly depicts that that data is expected to be tagged and that is the default state (all it's clients even define this parameter as 'true' by default). Data being un-taggged is the special case and <TAGGED> exists to handle that special case itself. -- To view, visit http://gerrit.cloudera.org:8080/17592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72912ae9353b0d567a976ca712d2d193e035df9b Gerrit-Change-Number: 17592 Gerrit-PatchSet: 12 Gerrit-Owner: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Aug 2021 14:51:37 +0000 Gerrit-HasComments: Yes
