Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17756 )
Change subject: [WIP]: Initial commit: Add logic to sync to latest event id ...................................................................... Patch Set 17: (12 comments) http://gerrit.cloudera.org:8080/#/c/17756/17/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/17756/17/be/src/catalog/catalog-server.cc@116 PS17, Line 116: DEFINE_bool(enable_catalogd_cache_sync_to_latest_event_id, false, "This configuration is used " line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/be/src/catalog/catalog-server.cc@117 PS17, Line 117: "only if start_hms_server is true. This is used to sync db/table in catalogd cache to " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/be/src/catalog/catalog-server.cc@118 PS17, Line 118: "latest hms event id whenever DDL operations are performed from Impala shell and catalog " line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@715 PS17, Line 715: org.apache.impala.catalog.Table tbl = getTableAndAcquireWriteLock(partition.getDbName(), line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@741 PS17, Line 741: org.apache.impala.catalog.Table tbl = getTableAndAcquireWriteLock(partition.getDbName(), line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@983 PS17, Line 983: boolean resp = super.drop_partition_by_name_with_environment_context(dbName, tableName, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1021 PS17, Line 1021: String sourceDbWithCatalog, String sourceTbl, String destDbWithCatalog, String destTbl) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@1070 PS17, Line 1070: String sourceDbWithCatalog, String sourceTbl, String destDbWithCatalog, String destTbl) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java File fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java: http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java@47 PS17, Line 47: APPEND_PARTITION_BY_NAME_WITH_ENVIRONMENT_CONTEXT("append_partition_by_name_with_environment_context"), line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java@51 PS17, Line 51: DROP_PARTITION_BY_NAME_WITH_ENVIRONMENT_CONTEXT("drop_partition_by_name_with_environment_context"), line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2996 PS17, Line 2996: + "sync to latest event id is set to true", dbNameWithCatalog, tableName, apiName); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java: http://gerrit.cloudera.org:8080/#/c/17756/17/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@562 PS17, Line 562: private Map<String, String> getPartitionSpec(org.apache.hadoop.hive.metastore.api.Table tbl, List<String> vals) { line too long (117 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia822d15725d0a9a9ad1398e10ed4ae3288d0e9ad Gerrit-Change-Number: 17756 Gerrit-PatchSet: 17 Gerrit-Owner: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Aug 2021 17:50:02 +0000 Gerrit-HasComments: Yes
