Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 )
Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/17765/2/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/17765/2/tests/query_test/test_iceberg.py@178 PS2, Line 178: t flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/17765/2/tests/query_test/test_iceberg.py@183 PS2, Line 183: t flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/17765/2/tests/query_test/test_iceberg.py@189 PS2, Line 189: t flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/17765/2/tests/query_test/test_iceberg.py@194 PS2, Line 194: t flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/17765/2/tests/query_test/test_iceberg.py@201 PS2, Line 201: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/17765/2/tests/query_test/test_iceberg.py@207 PS2, Line 207: flake8: E261 at least two spaces before inline comment -- To view, visit http://gerrit.cloudera.org:8080/17765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib523c5e47b8d9c377bea39a82fe20249177cf824 Gerrit-Change-Number: 17765 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Aug 2021 12:13:14 +0000 Gerrit-HasComments: Yes
