Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17812 )
Change subject: IMPALA-10888: getPartitionsByNames should return sorted partitions ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17812/2/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java File fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java: http://gerrit.cloudera.org:8080/#/c/17812/2/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java@459 PS2, Line 459: for (FieldSchema partSchema : partitionKeys) { Assuming retPartitions list is non empty, should we assert that partitionKeys.size() == retPartitions.get(0).getValues().size() ? -- To view, visit http://gerrit.cloudera.org:8080/17812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75aa9d714e888ec7f7efd62e475ba1d3a3342256 Gerrit-Change-Number: 17812 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <kis...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Aug 2021 17:24:09 +0000 Gerrit-HasComments: Yes
