Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17638 )
Change subject: IMPALA-9495: Support struct in select list for ORC tables ...................................................................... Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/17638/13/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/17638/13/tests/authorization/test_ranger.py@1579 PS13, Line 1579: class TestRangerColumnMaskingComplexTypesInSelectList(CustomClusterTestSuite): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/17638/13/tests/authorization/test_ranger.py@1621 PS13, Line 1621: > flake8: W292 no newline at end of file Done http://gerrit.cloudera.org:8080/#/c/17638/13/tests/common/test_dimensions.py File tests/common/test_dimensions.py: http://gerrit.cloudera.org:8080/#/c/17638/13/tests/common/test_dimensions.py@109 PS13, Line 109: def create_orc_dimension(workload): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/17638/13/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/17638/13/tests/query_test/test_nested_types.py@155 PS13, Line 155: class TestNestedTypesInSelectListWithBeeswax(ImpalaTestSuite): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/17638/13/tests/query_test/test_nested_types.py@177 PS13, Line 177: class TestComputeStatsWithNestedTypes(ImpalaTestSuite): > flake8: E302 expected 2 blank lines, found 1 Done -- To view, visit http://gerrit.cloudera.org:8080/17638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fbe56bdcd372b72e99c0195d87a818e7fa4bc3a Gerrit-Change-Number: 17638 Gerrit-PatchSet: 13 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 30 Aug 2021 13:51:24 +0000 Gerrit-HasComments: Yes