Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17858 )
Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2604 PS1, Line 2604: public boolean reloadTableIfExists(String dbName, String tblName, long eventId, String reason) line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2610 PS1, Line 2610: LOG.debug("Not reloading the table {}.{} since it is recreated.", dbName, tblName); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1709 PS1, Line 1709: Preconditions.checkState(eventType_.equals(MetastoreEventType.ALLOC_WRITE_ID_EVENT)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1712 PS1, Line 1712: MetastoreEventsProcessor.getMessageDeserializer().getAllocWriteIdMessage(event.getMessage()); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1081 PS1, Line 1081: Path parentPath = partition == null ? new Path(msTbl.getSd().getLocation()) : new Path(partition.getSd().getLocation()); line too long (124 > 90) http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1083 PS1, Line 1083: List<String> newFiles = addFilesToDirectory(deltaPath, "testFile.", totalNumberOfFilesToAdd, false); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2283 PS1, Line 2283: private void testInsertIntoTransactionalTable(String tblName, boolean toAbort, boolean isPartitioned) line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2297 PS1, Line 2297: long writeId = MetastoreShim.allocateTableWriteId(client.getHiveClient(), txnId, TEST_DB_NAME, tblName); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2304 PS1, Line 2304: partition = client.getHiveClient().getPartition(TEST_DB_NAME, tblName, Arrays.asList("1")); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17858/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3088 PS1, Line 3088: TEST_DB_NAME, tblName, test_insert_tbl, updated_partitions, isOverwrite, txnId, writeId); line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ba07c9a338a25614690e314335ee4b801486da9 Gerrit-Change-Number: 17858 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Sep 2021 18:29:42 +0000 Gerrit-HasComments: Yes
