Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17802 )
Change subject: IMPALA-10876: Support to download JWKS from given URL ...................................................................... Patch Set 4: (1 comment) Thanks for the changes, I'm working my way through. I had one initial comment. http://gerrit.cloudera.org:8080/#/c/17802/4/be/src/kudu/util/curl_util.h File be/src/kudu/util/curl_util.h: http://gerrit.cloudera.org:8080/#/c/17802/4/be/src/kudu/util/curl_util.h@17 PS4, Line 17: : #pragma once : : #include <cstddef> : #include <string> : #include <utility> : #include <vector> : : #include "kudu/gutil/macros.h" : #include "kudu/util/monotime.h" : #include "kudu/util/status.h" : : typedef void CURL; : : namespace kudu { : : class faststring; : : enum class CurlAuthType { : NONE, : BASIC, : DIGEST, : SPNEGO, : }; : : // Simple wrapper around curl's "easy" interface, allowing the user to : // fetch web pages into memory using a blocking API. : // : // This is not thread-safe. : class EasyCurl { : public: : EasyCurl(); : ~EasyCurl(); : : // Fetch the given URL into the provided buffer. : // Any existing data in the buffer is replaced. : // The optional param 'headers' holds additional headers. : // e.g. {"Accept-Encoding: gzip"} : Status FetchURL(const std::string& url, : faststring* dst, : const std::vector<std::string>& headers = {}); : : // Issue an HTTP POST to the given URL with the given data. : // Returns results in 'dst' as above. : // The optional param 'headers' holds additional headers. : // e.g. {"Accept-Encoding: gzip"} : Status PostToURL(const std::string& url, : const std::string& post_data, : faststring* dst, : const std::vector<std::string>& headers = {}); : : // Set whether to verify the server's SSL certificate in the case of an HTTPS : // connection. : void set_verify_peer(bool verify) Can we split out the change to be/src/kudu into its own commit? That commit can list out which Kudu JIRAs are being incorporated. It will be a bit of logistic annoyance, but that will keep it clear what we are doing to be/src/kudu. -- To view, visit http://gerrit.cloudera.org:8080/17802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6ac8cf0010c13db30219776d1d275709bf211df Gerrit-Change-Number: 17802 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 22 Sep 2021 22:22:00 +0000 Gerrit-HasComments: Yes
