Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17848 )
Change subject: IMPALA-9857: Batching of consecutive partition events ...................................................................... Patch Set 7: (3 comments) > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7482/ One of the test which failed was caused by the changes to the last patch set. The other test which failed doesn't look related to this patch. I will retrigger the precommit once more. http://gerrit.cloudera.org:8080/#/c/17848/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/17848/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2716 PS7, Line 2716: does not them > nit: missing 'include'? Done http://gerrit.cloudera.org:8080/#/c/17848/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/17848/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1792 PS6, Line 1792: > This indentation is inconsistent with L1812 (I think the latter is the corr Thanks for the detailed example. I will try to see if I can change my IDE settings to change this. manually fixed it for now. http://gerrit.cloudera.org:8080/#/c/17848/7/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/17848/7/tests/custom_cluster/test_events_custom_configs.py@270 PS7, Line 270: batch_events_2 > batch_events_1 > I think we should convert them to integers before comparing them. Actually I found that all the instances of get_event_processor_metric needed a int. Hence I changed the method to return the int now. -- To view, visit http://gerrit.cloudera.org:8080/17848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d27a68a64436d31731e9a219b1efd6fc842de73 Gerrit-Change-Number: 17848 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 23 Sep 2021 20:59:20 +0000 Gerrit-HasComments: Yes
