Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller ...................................................................... Patch Set 2: (2 comments) QQ to see if I understand what is going on http://gerrit.cloudera.org:8080/#/c/17893/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17893/2//COMMIT_MSG@10 PS2, Line 10: objects tracking state required for queuing where being retained Nit: "were" being retained http://gerrit.cloudera.org:8080/#/c/17893/2//COMMIT_MSG@12 PS2, Line 12: Is the point of this change that this code is wrong in the old version because queued was a pointer and so never zero (false)? const auto queue_node_deleter = MakeScopeExitTrigger([&]() { if (!queued) { lock_guard<mutex> lock(queue_nodes_lock_); queue_nodes_.erase(request.query_id); } }); -- To view, visit http://gerrit.cloudera.org:8080/17893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1 Gerrit-Change-Number: 17893 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: abeltian <abelt...@tencent.com> Gerrit-Comment-Date: Fri, 01 Oct 2021 20:41:38 +0000 Gerrit-HasComments: Yes
