Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17811 )
Change subject: POC IMPALA-9498: Allow returning arrays in select list ...................................................................... Patch Set 12: (8 comments) http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1309 PS12, Line 1309: public SlotDescriptor registerSlotRef(Path slotPath, boolean duplicateCollections) throws AnalysisException { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1332 PS12, Line 1332: //CollectionTableRef collTblRef = (CollectionTableRef) analyzer.resolveTableRef(tblRef); //new CollectionTableRef(tblRef, currentPath, true); line too long (150 > 90) http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java File fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java: http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java@63 PS12, Line 63: String parentAlias = resolvedPath.getRootDesc() == null ? null : resolvedPath.getRootDesc().getAlias(); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java@99 PS12, Line 99: SlotDescriptor parentSlotDesc = analyzer.registerSlotRef(resolvedPath_/*, !inSelectList_*/); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java@159 PS12, Line 159: public boolean setIsCollectionInSelectList(boolean value) { return inSelectList_ = true; } line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@327 PS12, Line 327: String parentTupleId = (parent_ == null ? "null" : String.valueOf(parent_.getId().asInt())); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@328 PS12, Line 328: String itemTupleId = (itemTupleDesc_ == null ? "null" : String.valueOf(itemTupleDesc_.getId().asInt())); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/SlotRef.java File fe/src/main/java/org/apache/impala/analysis/SlotRef.java: http://gerrit.cloudera.org:8080/#/c/17811/12/fe/src/main/java/org/apache/impala/analysis/SlotRef.java@155 PS12, Line 155: //CollectionTableRef collTblRef = (CollectionTableRef) analyzer.resolveTableRef(tblRef); //new CollectionTableRef(tblRef, currentPath, true); line too long (150 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e42ffb21c7ddc033aba0f754b0108e46f34d0 Gerrit-Change-Number: 17811 Gerrit-PatchSet: 12 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 18:46:42 +0000 Gerrit-HasComments: Yes
