Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17855 )
Change subject: IMPALA-10921 Add script to compare TPCDS runs. ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/17855/4/bin/diagnostics/experimental/tpcds_run_comparator.py File bin/diagnostics/experimental/tpcds_run_comparator.py: http://gerrit.cloudera.org:8080/#/c/17855/4/bin/diagnostics/experimental/tpcds_run_comparator.py@39 PS4, Line 39: # tpcds_run_comparator.py <path to base run profile> <path to new run profile> > Update the example usage with <path to result csv file> ? done. http://gerrit.cloudera.org:8080/#/c/17855/4/bin/diagnostics/experimental/tpcds_run_comparator.py@247 PS4, Line 247: writer.writerows(ht_mem_res) : header2 = ['TPCDS query profile', 'base avg (MB)', 'new avg (MB)', > What I meant in my comment before was to split the output table to 2 separa Yes, it prints to one file. Having 2 files would be unnecessary for same analysis. I envision this script to have multiple analysis in future like peak memory analysis and each analysis would having multiple comparison metric (max per-operator peak memory, node peak memory etc). It is ok to have separate csv for every analysis, but having it for every comparison would be an overkill. -- To view, visit http://gerrit.cloudera.org:8080/17855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e9ae1a2919156b0022072f47ff71d7775b20e6 Gerrit-Change-Number: 17855 Gerrit-PatchSet: 5 Gerrit-Owner: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Oct 2021 11:58:57 +0000 Gerrit-HasComments: Yes
