Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17910 )
Change subject: IMPALA-10958: Decouple getConstraintsInformation from hive.ql.metadata.Table ...................................................................... IMPALA-10958: Decouple getConstraintsInformation from hive.ql.metadata.Table After HIVE-22782, ql.metadata.Table object has no methods to set PrimaryKeyInfo and ForeignKeyInfo alone. However, we call these two functions In DescribeResultFactory to set constraints and pass the table into HiveMetadataFormatUtils. Instead of calling the methods from table, we can directly pass PrimaryKeyInfo and ForeignKeyInfo to HiveMetadataFormatUtils so that Impala won't be influenced even though the table class changes interface. Additionally, we can get rid of ql.metadata.Table for getTableInformation altogether since it just needs metastore.api.Table internally. Tests: Ran core tests. Change-Id: I2dfc54ae2f995dc4ab735d17dbbad9a48f6633da Reviewed-on: http://gerrit.cloudera.org:8080/17910 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Vihang Karajgaonkar <vih...@cloudera.com> --- M fe/src/compat-hive-3/java/org/apache/impala/compat/HiveMetadataFormatUtils.java M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java 3 files changed, 15 insertions(+), 22 deletions(-) Approvals: Impala Public Jenkins: Verified Vihang Karajgaonkar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2dfc54ae2f995dc4ab735d17dbbad9a48f6633da Gerrit-Change-Number: 17910 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com>
