Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17933 )
Change subject: IMPALA-10836: Add 'SimplifyCastExprRule' rule to rewrite cast expr in some situations ...................................................................... Patch Set 3: Code-Review+1 (5 comments) Just found some nits/grammatical errors, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/17933/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17933/3//COMMIT_MSG@10 PS3, Line 10: e nit: we use 72 chars width lines in commit messages http://gerrit.cloudera.org:8080/#/c/17933/3//COMMIT_MSG@11 PS3, Line 11: is nit: are http://gerrit.cloudera.org:8080/#/c/17933/3/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java File fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java: http://gerrit.cloudera.org:8080/#/c/17933/3/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java@26 PS3, Line 26: simplify nit: simplifies http://gerrit.cloudera.org:8080/#/c/17933/3/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java@42 PS3, Line 42: length are same. nit: lengths are the same http://gerrit.cloudera.org:8080/#/c/17933/3/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java@43 PS3, Line 43: precision and scale are same. nit: precisions and scales are the same -- To view, visit http://gerrit.cloudera.org:8080/17933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8fac7100060d4e139a8b24d4795c6f279c55954 Gerrit-Change-Number: 17933 Gerrit-PatchSet: 3 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Mon, 25 Oct 2021 14:01:23 +0000 Gerrit-HasComments: Yes
