Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17982/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/17982/2/buildall.sh@464 PS2, Line 464: local build_type=$1 : local gcov_ > Both of these variables should be declared "local" (see L489). The name "bu Thanks for catching this. Done. -- To view, visit http://gerrit.cloudera.org:8080/17982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c Gerrit-Change-Number: 17982 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Oct 2021 10:36:00 +0000 Gerrit-HasComments: Yes
