Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 )
Change subject: IMPALA-10926: Improve catalogd consistency and self events detection ...................................................................... Patch Set 27: (3 comments) http://gerrit.cloudera.org:8080/#/c/17859/27/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/17859/27/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2423 PS27, Line 2423: * String, long)} which passes false for {@code refreshUpdatedPartitions} argument and ignore line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17859/27/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17859/27/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5878 PS27, Line 5878: updatedThriftTable = catalog_.reloadTable(tbl, req, resultType, cmdString, -1); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17859/27/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/17859/27/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2471 PS27, Line 2471: batchEvents = eventFactory.createBatchEvents(mockEvents, eventsProcessor_.getMetrics()); line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36364e401911352c4666674eb98c8d61bbaae9b9 Gerrit-Change-Number: 17859 Gerrit-PatchSet: 27 Gerrit-Owner: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <kis...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Comment-Date: Mon, 08 Nov 2021 12:41:03 +0000 Gerrit-HasComments: Yes
