Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17811 )
Change subject: WIP IMPALA-9498: Allow returning arrays in select list ...................................................................... Patch Set 19: (3 comments) Looks great. Thanks! http://gerrit.cloudera.org:8080/#/c/17811/17/be/src/exprs/expr.h File be/src/exprs/expr.h: http://gerrit.cloudera.org:8080/#/c/17811/17/be/src/exprs/expr.h@82 PS17, Line 82: virtual const TupleDescriptor* GetCollectionTupleDesc() const { : DCHECK(false); : return nullptr; : } > Declaring this abstract would mean that I will have to implement it in ever Done http://gerrit.cloudera.org:8080/#/c/17811/17/be/src/service/hs2-util.cc File be/src/service/hs2-util.cc: http://gerrit.cloudera.org:8080/#/c/17811/17/be/src/service/hs2-util.cc@418 PS17, Line 418: RawValue::PrintArrayValue(&value, item_tuple_desc, - > I agree that there should be some kind of limit, but StringValue::MAX_LENGT Sounds like a good plan. Maybe we could offer compressed JSON, such as BSON for the same purpose. http://gerrit.cloudera.org:8080/#/c/17811/17/fe/src/main/java/org/apache/impala/catalog/Type.java File fe/src/main/java/org/apache/impala/catalog/Type.java: http://gerrit.cloudera.org:8080/#/c/17811/17/fe/src/main/java/org/apache/impala/catalog/Type.java@356 PS17, Line 356: } else if (t1.isArrayType() && t2.isArrayType()) { > yes, this is exactly what we are checking here - the two types must be exac Okay. The limitation is due to BE's limitation. Looks like we probably should file a JIRA about it and add a comment here. The extended compatibility will be useful in practice, such as UNION from two tables with ARRAY(SMALLINT) and ARRAY(INT). -- To view, visit http://gerrit.cloudera.org:8080/17811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e42ffb21c7ddc033aba0f754b0108e46f34d0 Gerrit-Change-Number: 17811 Gerrit-PatchSet: 19 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Nov 2021 16:33:44 +0000 Gerrit-HasComments: Yes
