Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18019 )
Change subject: IMPALA-11027: Adding flag to enable support for ShellBasedUnixGroupMapping ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18019/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18019/2//COMMIT_MSG@7 PS2, Line 7: ShellBasedUnixGroupMapping nit: ShellBasedUnixGroupsMapping (missing 's' for Groups) http://gerrit.cloudera.org:8080/#/c/18019/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/18019/2/be/src/service/frontend.cc@77 PS2, Line 77: group nit: maybe 'groups' here as well? http://gerrit.cloudera.org:8080/#/c/18019/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/18019/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@826 PS2, Line 826: && : BackendConfig.INSTANCE.isShellBasedGroupMappingEnabled() Shouldn't it be !BackendConfig.INSTANCE.isShellBasedGroupMappingEnabled()? IIUC we want to raise an error when the flag is false. -- To view, visit http://gerrit.cloudera.org:8080/18019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I023f396a79f3aa27ad6ac80e91f527058a5a5470 Gerrit-Change-Number: 18019 Gerrit-PatchSet: 2 Gerrit-Owner: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Nov 2021 17:00:00 +0000 Gerrit-HasComments: Yes
