Aman Sinha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18037 )

Change subject: IMPALA-11029: DescriptorTable.copyTupleDescriptor throw 
exception for Kudu table
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18037/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18037/2//COMMIT_MSG@23
PS2, Line 23: coping
nit: copying


http://gerrit.cloudera.org:8080/#/c/18037/2/fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java
File fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java:

http://gerrit.cloudera.org:8080/#/c/18037/2/fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java@81
PS2, Line 81:     if (src.getPath() != null) d.setPath(src.getPath());
This change makes sense to me. I was thinking why we only see the issue for 
this scenario. It seems 2 things are needed to hit this bug: Kudu tables (due 
to the 4 byte string padding) and it must be an analytic function query (since 
only AnalyticEvalNode calls the copyTupleDescriptor().



--
To view, visit http://gerrit.cloudera.org:8080/18037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib88e005910134f2b7575c06fa02ce11890418a41
Gerrit-Change-Number: 18037
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Nov 2021 20:17:17 +0000
Gerrit-HasComments: Yes

Reply via email to