Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18062/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18062/1//COMMIT_MSG@10 PS1, Line 10: --redirect_stdout_stderr=false > is this also required to ensure no logs are generated? if yes, should we ad The default for redirect_stdout_stderr is true and in a server (not a unit test) if redirect_stdout_stderr is true then FLAGS_alsologtostderr is reset to be false. So I think the check on just FLAGS_alsologtostderr is sufficient. -- To view, visit http://gerrit.cloudera.org:8080/18062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3 Gerrit-Change-Number: 18062 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Dec 2021 19:42:04 +0000 Gerrit-HasComments: Yes
