Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18091 )
Change subject: IMPALA-11057: Speed to hex_int function ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/18091/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18091/4//COMMIT_MSG@9 PS4, Line 9: The origin HexInt method is too slow. Was there any analysis as to what was slow with stringstream? Perhaps re-using the stringstream across calls could be sufficient? http://gerrit.cloudera.org:8080/#/c/18091/4/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/18091/4/be/src/exprs/math-functions-ir.cc@242 PS4, Line 242: char hex[] = {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', Declare static const http://gerrit.cloudera.org:8080/#/c/18091/4/be/src/exprs/math-functions-ir.cc@254 PS4, Line 254: for (int k = 0, j = i - 1; k <= j; k++, j--) { Wrap with: #if __BYTE_ORDER == __LITTLE_ENDIAN -- To view, visit http://gerrit.cloudera.org:8080/18091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf2dc7ea64b60b24f1a9e6ab53725acd40ce88ac Gerrit-Change-Number: 18091 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Mon, 13 Dec 2021 16:48:38 +0000 Gerrit-HasComments: Yes
