Kurt Deschler has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18093 )

Change subject: IMPALA-11033: Add support for specifying multiple executor 
group sets
......................................................................


Patch Set 2:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/runtime/exec-env.cc@178
PS2, Line 178:     const vector<pair<string, int>>& expected_exec_group_sets, 
Frontend* frontend) {
typedef for ExecGroupSets


http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr-test.cc
File be/src/scheduling/cluster-membership-mgr-test.cc:

http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr-test.cc@556
PS2, Line 556:   vector<pair<string, int>> expected_exec_group_sets;
use ExecGroupSets typedef here.


http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr-test.cc@753
PS2, Line 753:
negative test for duplicate names or invalid parameters?


http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr.h
File be/src/scheduling/cluster-membership-mgr.h:

http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr.h@173
PS2, Line 173:   const std::vector<std::pair<std::string, int>>& 
GetExpectedExecGroupSets() {
use ExecGroupSets typedef


http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr.h@221
PS2, Line 221:       std::vector<std::pair<std::string, int>>& 
expected_exec_group_sets);
use ExecGroupSets typedef


http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr.h@229
PS2, Line 229:   std::vector<std::pair<std::string, int>> 
expected_exec_group_sets_;
use ExecGroupSets typedef


http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr.h@285
PS2, Line 285:     const std::vector<std::pair<std::string, int>>& 
expected_exec_group_sets,
use ExecGroupSets typedef


http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr.cc
File be/src/scheduling/cluster-membership-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr.cc@688
PS2, Line 688:         return first.second < second.second;
could either DCHECK first.second!=second.second or make strong order to handle 
dups deterministically.



--
To view, visit http://gerrit.cloudera.org:8080/18093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0a3a5fe2b1f0b7507b7c096b7a3c373bc2e684
Gerrit-Change-Number: 18093
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Dec 2021 03:35:47 +0000
Gerrit-HasComments: Yes

Reply via email to