Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17811 )
Change subject: IMPALA-9498: Allow returning arrays in select list ...................................................................... Patch Set 28: (5 comments) http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@713 PS28, Line 713: public void addAlias(String alias, TupleDescriptor desc) { : aliasMap_.put(alias, desc); : } Is this used somewhere? http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@392 PS28, Line 392: "complex-typed exprs " + : "are currently not supported in the select list nit: I think we should update this as well http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@400 PS28, Line 400: if (!arrayType.getItemType().isSupported()) { Should we check the subtypes recursively here? Do we have test coverage for unsupported types like array<array<array<binary>>>? It seems isSupported() always returns true for complex types. Maybe we should check whether the leaf subtypes are supported, and whether there are STRUCT types inside arrays here. http://gerrit.cloudera.org:8080/#/c/17811/28/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@544 PS28, Line 544: List<CollectionTableRef> collections = new ArrayList<>(); Unused? http://gerrit.cloudera.org:8080/#/c/17811/28/testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test File testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test: http://gerrit.cloudera.org:8080/#/c/17811/28/testdata/workloads/functional-query/queries/QueryTest/nested-array-in-select-list.test@36 PS28, Line 36: ==== Could you add a test about selecting both STRUCT and ARRAY columns? -- To view, visit http://gerrit.cloudera.org:8080/17811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e42ffb21c7ddc033aba0f754b0108e46f34d0 Gerrit-Change-Number: 17811 Gerrit-PatchSet: 28 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 06:26:27 +0000 Gerrit-HasComments: Yes
