Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17771 )
Change subject: WiP: IMPALA-10798 : Prototype for JSON reader ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc File be/src/exec/hdfs-json-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17771/12/be/src/exec/hdfs-json-scanner.cc@297 PS12, Line 297: *(reinterpret_cast<int32_t*>(slot_val_ptr)) = int_arr.Value(i - start_pos_); I think we are not handling null values. We should check int_arr.IsNull(i - start_pos_) somewhere or check int_arr.IsValid(i - start_pos_) before using int_arr.Value(). -- To view, visit http://gerrit.cloudera.org:8080/17771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79364a421d862d0d837f9be694911e388d4d629 Gerrit-Change-Number: 17771 Gerrit-PatchSet: 12 Gerrit-Owner: Anonymous Coward <shikha.asran...@gmail.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <shikha.asran...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 01:04:47 +0000 Gerrit-HasComments: Yes
