Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18017 )
Change subject: IMPALA-10910, IMPALA-5509: Runtime filter: dictionary filter support ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18017/4/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18017/4/be/src/exec/parquet/hdfs-parquet-scanner.cc@1918 PS4, Line 1918: break; > My understanding is that runtime filters are in AND relationship, so all of Yeah, sometimes there is no clear answer to who rejected the row group. Probably we should just increment the "Filter processed" counter for the filters that were actually evaluated. And use 'num_dict_filtered_row_groups_counter_' to count the number of rejected row groups, either by conjuncts or runtime filters, or by their combination. Sometimes there's a clear answer to who rejected the row group. E.g. if a filter was evaluated to all entries and it was always false, then we have a clear winner. -- To view, visit http://gerrit.cloudera.org:8080/18017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida0ada8799774be34312eaa4be47336149f637c7 Gerrit-Change-Number: 18017 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:50:21 +0000 Gerrit-HasComments: Yes
