Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18033 )
Change subject: IMPALA-10934 (Part 2): Enable table definition over a single file ...................................................................... Patch Set 7: > Patch Set 7: > > > Patch Set 6: > > > > > Patch Set 6: > > > > > > (1 comment) > > > > > > > Patch Set 6: Verified-1 > > > > > > > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7712/ > > > > > > Fang-Yu, could you address the LOCATION related failure as mentioned > > > below? > > > More details of the error: > > > https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/5080/ > > > > Taking a closer look at the console output of the Jenkins job, I think I > > should use $DEFAULT_FS to replace each occurrence of > > "hdfs://localhost:20500" since $DEFAULT_FS is not necessarily > > "hdfs://localhost:20500" in every test environment. > > In the updated patch set (patch set 7), I replaced each occurrence of > "localhost" with $INTERNAL_LISTEN_HOST since this is a string that will be > replaced in our test framework according to > https://github.com/apache/impala/blob/master/tests/common/impala_test_suite.py#L534L535. The link above was wrong. I think it should be https://github.com/apache/impala/blob/master/tests/common/impala_test_suite.py#L470 instead. But the patch should still pass according to my current understanding. -- To view, visit http://gerrit.cloudera.org:8080/18033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f57f07a9f543c660b102ebf307a6cf590a6784 Gerrit-Change-Number: 18033 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k...@rxd.hu> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 20:29:19 +0000 Gerrit-HasComments: No
