Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18125
to look at the new patch set (#4).
Change subject: IMPALA-11070: Create TestSection class.
......................................................................
IMPALA-11070: Create TestSection class.
Create a TestSection class that holds logic regarding
sections in a ".test" file.
This commit will contain only movement of code without
any logic changes. Future commits will move some of the
section related code into TestSection where it belongs,
including string replacements, and related sections code
(e.g. DML_RESULTS and RESULTS).
The caller methods are translated as follows:
if a in test_section -> if test_section.has_section(a)
a[section_name] -> test_section.get_section(a)
a.get(section_name) -> test_section.get_section_with_default(a, None)
a.get(section_name, default) ->
test_section.get_section_with_default(a, default)
Change-Id: I3fed7ef64ac263b49b5b6e4a237a296092e4dcb8
---
M testdata/bin/generate-schema-statements.py
M tests/common/impala_test_suite.py
M tests/common/test_result_verifier.py
A tests/common/test_section.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_views_compatibility.py
M tests/unittests/test_file_parser.py
M tests/util/test_file_parser.py
8 files changed, 291 insertions(+), 209 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/18125/4
--
To view, visit http://gerrit.cloudera.org:8080/18125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3fed7ef64ac263b49b5b6e4a237a296092e4dcb8
Gerrit-Change-Number: 18125
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <scar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
