Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17946 )
Change subject: IMPALA-10951 (part 1): Upgrade protobuf library in toolchain ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/17946/10/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/17946/10/buildall.sh@125 PS10, Line 125: # 3.14.0-p2-p2 is only used for Clang builds. : PROTOBUF_VERSION=3.14.0-p2 $SOURCE_DIR/source/protobuf/build.sh > We can tell these apart by their patch numbers, but I think would rather in Good suggestion, will rename the version as "3.14.0-clangcompat-p2", and make corresponding changes for source/protobuf/build.sh. -- To view, visit http://gerrit.cloudera.org:8080/17946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6700d4f8956fb2bdff5fea3bef2572352f175f67 Gerrit-Change-Number: 17946 Gerrit-PatchSet: 10 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Jan 2022 20:08:07 +0000 Gerrit-HasComments: Yes
