Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 )
Change subject: IMPALA-6636: Use async IO in ORC scanner ...................................................................... Patch Set 21: (3 comments) Patch set 21 add some more logging informations. http://gerrit.cloudera.org:8080/#/c/15370/20/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15370/20/be/src/exec/hdfs-orc-scanner.cc@202 PS20, Line 202: if (last_end > range.offset_) { : string msg = : Substitute("Ove > Missing $1 in the string template. Done http://gerrit.cloudera.org:8080/#/c/15370/20/be/src/exec/hdfs-orc-scanner.cc@246 PS20, Line 246: if (offset + length > offset_ + length_) { : string msg = Substitute("ORC read request out of range. offset: $0 length: $1 $2", : offset, length, > Need to add filename here and some other site to help debugging if such err Done http://gerrit.cloudera.org:8080/#/c/15370/20/be/src/exec/hdfs-orc-scanner.cc@951 PS20, Line 951: return parse_status_; : } catch (std::exception& e) { > Add filename information in this error logging. Done -- To view, visit http://gerrit.cloudera.org:8080/15370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348ad9e55f0cae7dff0d74d941b026dcbf5e4074 Gerrit-Change-Number: 15370 Gerrit-PatchSet: 21 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Jan 2022 19:40:29 +0000 Gerrit-HasComments: Yes
