Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/18080 )
Change subject: IMPALA-11056: Create option to fail query on Java UDF exceptions ...................................................................... Patch Set 3: (5 comments) A few minor comments. http://gerrit.cloudera.org:8080/#/c/18080/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18080/3//COMMIT_MSG@10 PS3, Line 10: abort_java_udf_on_execution" typo: 'exception' instead of 'execution' http://gerrit.cloudera.org:8080/#/c/18080/3/be/src/exprs/hive-udf-call-ir.cc File be/src/exprs/hive-udf-call-ir.cc: http://gerrit.cloudera.org:8080/#/c/18080/3/be/src/exprs/hive-udf-call-ir.cc@71 PS3, Line 71: } Same comment as above. http://gerrit.cloudera.org:8080/#/c/18080/3/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: http://gerrit.cloudera.org:8080/#/c/18080/3/be/src/exprs/hive-udf-call.cc@122 PS3, Line 122: } Could you move the closing brace after the warning_logged = true statement to be consistent with how it was before, even though the behavior does not change. http://gerrit.cloudera.org:8080/#/c/18080/3/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/18080/3/common/thrift/Query.thrift@571 PS3, Line 571: java udf nit: 'Java UDF' for consistency with how it is worded later in this comment. Same thing in the other thrift file. http://gerrit.cloudera.org:8080/#/c/18080/3/common/thrift/Query.thrift@571 PS3, Line 571: (legacy) nit: remove 'legacy' since that may be misinterpreted. -- To view, visit http://gerrit.cloudera.org:8080/18080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece20cf16a6575f1c498238f754440e870e2ce9 Gerrit-Change-Number: 18080 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Jan 2022 16:33:02 +0000 Gerrit-HasComments: Yes
